Fix (Relation): add safe navigator operator after scopes for respond_to_missing? and method_missing methods #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_missing? and method_missing methods
|
@Thornolf Thank you for pointing out this issue and suggesting a fix! Would you mind adding a test case that demonstrates the issue, to prevent regressions? |
Sure ! I will do it as soon as possible :) Thank you for the review ! |
|
Oh indeed, sorry for the delay I was a bit busy at work 😅 I did not even saw the PR myself sorry for creating this duplicate ! Thank you for merging it 💪🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
In our attempt to move our project to Ruby 3.2.2 we encountered an error :
MethodError: undefined method 'key?' for nil:NilClass, the origin of the error was fromrelation.rb:173, our class did not had any scopes and so it was sending this error. We had multiples ideas to fix the issue but the simplest one was to just add a safe navigator operator. What do you think about that ? I'm available if you need me to do any other modifications.Thank you !